testcontainers / testcontainers/testcontainers-python
what to do with DBContainer - split from removing sqlalchemy dependency
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.3k
- Forks
- 386
- Avg merge
- 4h 40m
- Merged PRs (30d)
- 1
Description
from https://github.com/testcontainers/testcontainers-python/pull/445#issuecomment-1985436334
After this discussion (with adding _wait_for_ready() and _configure() to the top level class), DBContainer would only contain this:
...
Anyway: I would appreciate if this conversation could be moved to a separate issue :-)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the discussion linked from PR #445 and the DBContainer and top-level class entry points first. Define done as reaching a decision about what remains in DBContainer after adding _wait_for_ready() and _configure() to the top-level class, including the SQLAlchemy-dependency context.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, python, sqlalchemy
- Domain
- backend, databases
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100