testcontainers / testcontainers/testcontainers-java
feature request: expand "Customizing Image Pull Behavior" to include a "platform" override
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Java
- Sterne
- 8.7k
- Forks
- 1.9k
- Ø Merge
- 2 T. 17 Std.
- Gemergte PRs (30 T.)
- 9
Beschreibung
In the "Customizing Image Pull Behavior" section:
https://java.testcontainers.org/features/configuration/#customizing-image-pull-behaviour
there is an ability to to specify the behavior of timeouts while pulling.
There is also "pull.policy" which is not documented here but only in another place (https://java.testcontainers.org/features/advanced_options/#image-pull-policy)
the idea is to add a "pull.platform" or "pull.default-platform" or something which will override the platform detected normally with the one given as a property.
The proposal, initially to provide a single value as an override, is amended to provide two settings. one of which is a list of platforms to attempt to use - say ["darwin/arm64", "linux/arm64", "linux/amd64"] - and another which is a boolean flag which says whether or not the first one is a strict requirement (if false - implicit last thing to try is the default behavior). if the flag is true, and the first parameter is not null, the image pull action fails if none of the archs are present.
and document it in this section.
pros:
satisfy the needs described here - https://github.com/testcontainers/testcontainers-java/issues/3810#issuecomment-1876900016
cons:
potentially a satisfactory solution can be contained in user code as here - https://java.testcontainers.org/features/advanced_options/#using-createcontainercmdmodifier
conclusion:
purpose of this issue is to determine whether or not this addition is welcome as it seems to solve a need based on the other thread (linked in pros section)
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Lesen Sie die Abschnitte „Customizing Image Pull Behavior“ und „Image Pull Policy“, überprüfen Sie anschließend das verlinkte Issue und den dokumentierten CreateContainerCmdModifier-Ansatz. Das Issue ist erst vollständig, nachdem die vorgeschlagenen Plattformeinstellungen und das Verhalten vereinbart, implementiert, getestet und dokumentiert wurden.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- docker, java
- Bereich
- devops, documentation
- Issue-Typ
- Feature
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Aktivitätsstatus
- Veraltet
- Klarheit
- Muss geklärt werden
- Anfängerfreundlichkeit
- 25/100