testcontainers / testcontainers/testcontainers-java

[Enhancement]: Add ability to supply network to ryuk container

未關閉
#8,167 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

client/podman type/enhancement
主要語言
Java
星號
8.7k
分支
1.9k
平均合併
2 天 17 小時
30 天內合併 PR
9

描述

Module

Core

Synopsis

This is required due to one aspect of rootless podman networking:

https://docs.podman.io/en/latest/markdown/podman-run.1.html#network-mode-net
Screenshot 2024-01-29 at 20 44 31

This implies that network is not picked up when runnig podman in rooless mode thus making it impossible for ryuk to communicate with other containers even if they were started with --network=bridge network

Proposal

Tescontainer can run using custom network (auto created via Network.createNetwork() or external) and ryuk in this case cannot be customized to use the same custom network. Some environmet can have restrictions on default network, or even have different access to each other. In this case ryuk could not see the containers at all.

Since Testcontainer already has custom env varible to override some functionality will be great to have custom varible to define:

  • custom expose port for ryuk
  • custom network name which ryuk container should connect during creation

Workaround in this case disable ryuk only.

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

首先追蹤 Ryuk 容器的建立流程,以及 Core 模組中現有的環境變數覆寫機制。確認如何提供自訂網路和公開連接埠,然後新增覆蓋測試,驗證 Ryuk 加入要求的網路並可透過設定的連接埠存取。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
docker, java
領域
networking, testing
Issue 類型
功能
難度
4/5
預估耗時
3-5 天
活躍度
冷清
描述清晰度
基本清楚
新手友好度
52/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。