testcontainers / testcontainers/testcontainers-java

ConcurrentModificationException using new Startable.dependsOn(startable)

Abierto
#1,722 4 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

resolution/acknowledged type/bug
Lenguaje dominante
Java
Estrellas
8.7k
Forks
1.9k
Merge medio
2 d 17 h
PR fusionados (30 d)
9

Descripción

I ran into an error in one of my TravisCI builds using the new dependsOn mechanism:

    13780 ERROR 🐳 [postgres:9.6.12]  - Could not start container
    java.util.ConcurrentModificationException
    	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1660)
    	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
    	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
    	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:550)
    	at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
    	at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:517)
    	at org.testcontainers.containers.GenericContainer.applyConfiguration(GenericContainer.java:510)
    	at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:301)
    	at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:285)
    	at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
    	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:283)
    	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:272)
    	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
    	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1654)
    	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
    	at java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
    	at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:746)
    	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
    	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
    	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
    	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
    	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)

My containers are defined like this:

	@Container
	public static PostgreSQLContainer<?> postgres = new PostgreSQLContainer<>()
					.withNetworkAliases("testpostgres")
					.withDatabaseName("testdb");
	
    @Container
    public static MicroProfileApplication<?> app = new MicroProfileApplication<>()
                    .withEnv("POSTGRES_HOSTNAME", "testpostgres")
                    .withEnv("POSTGRES_PORT", "5432")
                    .withAppContextRoot("/myservice")
                    .dependsOn(postgres);

Using the latest version of testcontainers (1.12.0), the exception lines up with this bit of code:

    private void applyConfiguration(CreateContainerCmd createCommand) {
        HostConfig hostConfig = buildHostConfig();
        createCommand.withHostConfig(hostConfig);

        // Set up exposed ports (where there are no host port bindings defined)
        ExposedPort[] portArray = exposedPorts.stream()
                .map(ExposedPort::new)
                .toArray(ExposedPort[]::new);  // << --- CONCURRENT MOD EX HERE

It should also be noted that I am starting my containers in parallel like this:

containersToStart.parallelStream().forEach(GenericContainer::start);

which should be OK, since I believe the main value of dependsOn is that it allows us to do parallel container start without needing to worry about dependencies.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza en GenericContainer.applyConfiguration, en el stream de exposedPorts, y sigue después las rutas de dependsOn y GenericContainer.start en paralelo que se muestran en el informe. Reproduce la configuración de PostgreSQL/aplicación con containersToStart.parallelStream().forEach(GenericContainer::start), y considera completado el issue cuando los contenedores dependientes se inicien sin ConcurrentModificationException.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
docker, java
Área
devops, testing
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.