sun.misc.Unsafe memory-access deprecation (JEP 471): JDK 24+ warns, and future deny-by-default JDKs will break ndarray raw buffers at runtime instead of falling back
還沒有人認領這個 Issue。
- 主要語言
- Java
- 星號
- 928
- 分支
- 227
- PR 合併指標
- 30 天內沒有已合併 PR
描述
Investigated and reported by AI, reviewed by me.
Summary
sun.misc.Unsafe memory-access methods are terminally deprecated (JEP 471, JDK 23) and JDK 24+ emits a runtime warning on first use (JEP 498). ndarray's raw buffer implementation triggers this warning today, and — more importantly — the way UnsafeReference detects Unsafe availability means that when a future JDK flips the default from warn to deny (planned for JDK 26 or later, see the OpenJDK integrity-by-default roadmap), raw buffers will fail at runtime instead of falling back to the non-Unsafe buffer path.
Current warning (JDK 24/25)
Seen with tensorflow-core-api / ndarray 1.2.0 on JDK 25:
WARNING: A terminally deprecated method in sun.misc.Unsafe has been called
WARNING: sun.misc.Unsafe::arrayBaseOffset has been called by org.tensorflow.ndarray.impl.buffer.raw.UnsafeMemoryHandle (file:.../tensorflow-ndarray-1.2.0.jar)
WARNING: Please consider reporting this to the maintainers of class org.tensorflow.ndarray.impl.buffer.raw.UnsafeMemoryHandle
WARNING: sun.misc.Unsafe::arrayBaseOffset will be removed in a future release
The latent problem: availability check won't detect deny mode
UnsafeReference's static initializer validates the Unsafe methods only by reflective existence check (Class.getDeclaredMethod(...)) — it never actually invokes one:
Under --sun-misc-unsafe-memory-access=deny (the future default), the methods still exist — they just throw UnsupportedOperationException when invoked. So:
UnsafeReference.isAvailable()returnstrueRawDataBufferFactory.canBeUsed()returnstrue, so callers take the raw-buffer path- The first real operation (e.g.
UnsafeMemoryHandle.fromArray→Unsafe.arrayIndexScale/arrayBaseOffset, or anygetByte/putFloat/copyMemory) throwsUnsupportedOperationExceptionat runtime
i.e. instead of degrading gracefully to the heap/nio buffer implementations, applications will start crashing on the first tensor buffer operation once they run on a deny-by-default JDK.
Suggested fixes
- Short term (small change): in
UnsafeReference's static initializer, probe by invocation rather than existence — e.g. callunsafe.arrayBaseOffset(byte[].class)inside the existingtryand also catchUnsupportedOperationException. Thendenymode cleanly disables raw buffers and the existing fallback path takes over. - Long term: migrate the raw buffer implementation to
VarHandleand/or the Foreign Function & Memory API (java.lang.foreign.MemorySegment), which are the JEP-sanctioned replacements. That also eliminates the startup warning entirely. Once the Unsafe methods are removed (final phase of JEP 471), no JVM flag will keep the current code working.
Workaround for users (for anyone landing here)
- JDK 24/25:
--sun-misc-unsafe-memory-access=allowsilences the warning. - Deny-by-default JDKs:
--sun-misc-unsafe-memory-access=warnkeeps raw buffers functional (theallowvalue is no longer accepted in that phase).
Environment
org.tensorflow:tensorflow-core-api:1.2.0/tensorflow-ndarray:1.2.0- JDK 25 (warning), any JDK ≥ 24 warns; behavior controlled by
--sun-misc-unsafe-memory-access
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 tensorflow-ndarray/src/main/java/org/tensorflow/ndarray/impl/buffer/raw/UnsafeReference.java 開始,檢查其靜態可用性檢查,接著追蹤 RawDataBufferFactory.canBeUsed() 到 UnsafeMemoryHandle 的進入點。驗證 deny mode 下的行為,並確保停用 raw buffer,讓現有的 heap/NIO fallback 能夠被選取,而不是在執行時失敗。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- java
- 領域
- backend
- Issue 類型
- 缺陷
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 活躍度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 65/100