NameScope interacts poorly with subscoping

System information

• Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
• OS Platform and Distribution (e.g., Linux Ubuntu 16.04 x86_64): macOS x86_64
• TensorFlow installed from (source or binary): source
• TensorFlow version (use command below): 0.5.0-SNAPSHOT
• Java version (i.e., the output of java -version): JDK 11

Describe the current behavior
I'm trying to debug test failures in tensorflow-framework, and noticed that the test sessions use tf = Ops.create(graph).withName("test");. This makes all the nodes have the name "test_" which makes things pretty tricky to debug. I changed it to tf = Ops.create(graph).withSubScope("test");, but now I'm getting test failures out of the optimizers with the following message:

[INFO] Running org.tensorflow.framework.optimizers.FtrlTest
[ERROR] Tests run: 5, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 0.455 s <<< FAILURE! - in org.tensorflow.framework.optimizers.FtrlTest
[ERROR] testFtrlWithL1  Time elapsed: 0.415 s  <<< ERROR!
java.lang.IllegalArgumentException: invalid name: 'test/var0_gradient_accumulator' does not match the regular expression [A-Za-z0-9.][A-Za-z0-9_.\-]*
	at org.tensorflow.framework.optimizers.FtrlTest.testFtrlWithL1(FtrlTest.java:166)

Describe the expected behavior

No test failures, and test nodes have the correct op names.

Code to reproduce the issue
Make the withSubScope change at line 44 in org.tensorflow.framework.utils.GraphTestSession.

Commencez à la ligne 44 de GraphTestSession de tensorflow-framework et comparez le comportement de Ops.withName("test") et Ops.withSubScope("test"). Reproduisez l’échec dans FtrlTest.testFtrlWithL1 à la ligne 166, puis examinez le nom généré et la validation de nom impliquée. La tâche est terminée lorsque les tests de l’optimiseur réussissent et que les nœuds de test conservent des noms d’Op valides et débogables.