tensorflow / tensorflow/java

Getting errors on copyright comment when trying to build PR

Open
#330 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
928
Forks
227
PR merge metrics
No merged PRs in 30d

Description

IDescribe the problem

I am getting errors on the copyright comment block when trying to build a PR.
The only differences I see are "Copyright 2020" vs "Copyright 2020-2021" and some additional spaces.
I made no change to the copyright block when I changed the code.

This is happening on many source files.

Provide the exact sequence of commands / steps that you executed before running into the problem

Create PR.

Any other info / logs
Error: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.11.1:check (spotless-check) on project tensorflow-framework: The following files had format violations:
3584
Error: src/main/java/org/tensorflow/framework/initializers/He.java
3585
Error: @@ -1,17 +1,18 @@
3586
Error: -/?Copyright?2020?The?TensorFlow?Authors.?All?Rights?Reserved.
3587
Error: +/
?Copyright?2020-2021?The?TensorFlow?Authors.?All?Rights?Reserved.
3588
Error:
3589
Error: -Licensed?under?the?Apache?License,?Version?2.0?(the?"License");
3590
Error: -you?may?not?use?this?file?except?in?compliance?with?the?License.
3591
Error: -You?may?obtain?a?copy?of?the?License?at
3592
Error: +?Licensed?under?the?Apache?License,?Version?2.0?(the?"License");
3593
Error: +?you?may?not?use?this?file?except?in?compliance?with?the?License.
3594
Error: +?You?may?obtain?a?copy?of?the?License?at
3595
Error:
3596
Error: -????http://www.apache.org/licenses/LICENSE-2.0
3597
Error: +?????http://www.apache.org/licenses/LICENSE-2.0
3598
Error:
3599
Error: -Unless?required?by?applicable?law?or?agreed?to?in?writing,?software
3600
Error: -distributed?under?the?License?is?distributed?on?an?"AS?IS"?BASIS,
3601
Error: -WITHOUT?WARRANTIES?OR?CONDITIONS?OF?ANY?KIND,?either?express?or?implied.
3602
Error: -See?the?License?for?the?specific?language?governing?permissions?and
3603
Error: -limitations?under?the?License.
3604
Error: -=======================================================================/
3605
Error: +?Unless?required?by?applicable?law?or?agreed?to?in?writing,?software
3606
Error: +?distributed?under?the?License?is?distributed?on?an?"AS?IS"?BASIS,
3607
Error: +?WITHOUT?WARRANTIES?OR?CONDITIONS?OF?ANY?KIND,?either?express?or?implied.
3608
Error: +?See?the?License?for?the?specific?language?governing?permissions?and
3609
Error: +?limitations?under?the?License.
3610
Error: +?=======================================================================
3611
Error: +?
/
3612
Error: package?org.tensorflow.framework.initializers;

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the formatting failure for src/main/java/org/tensorflow/framework/initializers/He.java and inspect how the copyright comment differs from Spotless's expected output. Run the Maven spotless-check goal against the affected files, then confirm that the source files pass the PR build without copyright or spacing violations.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.