swiftwasm / swiftwasm/JavaScriptKit
Avoid copying and re-encoding for String every time
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 986
- Forks
- 76
- Avg merge
- 21h 11m
- Merged PRs (30d)
- 4
Description
enum JSValue {
- case string(String)
+ case string(JSString)
}
+ class JSString: JSBridgeClass, StringProtocol {
+ internal let id: JavaScriptObjectRef
+ ...
+ }
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the JSValue enum, JSString, JSBridgeClass, StringProtocol, and JavaScriptObjectRef definitions in JavaScriptKit. Trace how string values are currently copied and re-encoded, then determine the scope needed for a JSString-backed representation. Done means String values use the proposed representation without the existing copying and re-encoding overhead.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, swift, wasm
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100