swiftwasm / swiftwasm/JavaScriptKit
Do we need new enum cases in `JSValue` for closures?
Open
Nobody has claimed this yet.
question
- Dominant language
- Swift
- Stars
- 986
- Forks
- 76
- Avg merge
- 21h 11m
- Merged PRs (30d)
- 4
Description
Now that JSClosure and JSOneshotClosure are no longer subclasses of JSFunction, how are they supposed to be converted to JSValue? Should the object case be used?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how JSClosure and JSOneshotClosure are converted into JSValue, especially their relationship to the existing JSFunction and object cases. The issue does not identify files, tests, or a settled expected representation; done requires deciding whether new enum cases are needed and defining the intended conversion behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, swift
- Domain
- api, web-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100