Incomplete documentation for [[services.http_checks]] section

Open
#1,899 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
52/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Tech stack
html
Domain
documentation

Research direction

Read reference/configuration.html.markerb and locate the [[services.http_checks]] example and surrounding [[services]] and [[http_service]] guidance. Clarify where the section belongs and how it relates to the configured internal port, then verify the rendered configuration documentation explains the placement unambiguously.

Written by the indexing model from the issue text.

Description

I found an issue with this document.

Title: App configuration (fly.toml)
Location: https://fly.io/docs/reference/configuration/
Source: https://github.com/superfly/docs/blob/main/reference/configuration.html.markerb

Describe the issue

The document provides example of the [[services.http_checks]] section, however it does not indicate where this section should be placed.

When placed at the top level of the fly.toml, which is most logical for those new to TOML, the http checks goes against port 8080, ignoring any custom internal port that may have been configured under the[[http_service]] section. I discovered that in order to go against the correct port, the [[services.http_checks]] needs to be placed under the [[services]] section that has defined the internal port.

This is an opportunity to improve the documentation.

Dominant language
HTML
Stars
128
Forks
1.1k
Avg merge
4d 15h
Merged PRs (30d)
12

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from superfly/docs

All issues in superfly/docs

Similar issues

More Documentation issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.