parity(auth): return null from session storage on JSON parse failure [from supabase-js]

Open
#263 0 comments 0 reactions 1 assignee View on GitHub

@Tr00d is already working on this.

Since Jul 1, 2026.

Assessment

This issue has not been assessed yet.

Description

parity

[!WARNING]
Auto-generated parity issue — may be a false positive.

This issue was created automatically by /sync-sdk-parity from a heuristic analysis of recent supabase-js commits. The tooling has limited insight into language-specific idioms and may have:

  • misidentified a JS-only change as cross-language relevant,
  • missed an existing implementation in this SDK under a different name,
  • or proposed an API shape that doesn't fit this language's conventions.

It is the SDK author's responsibility to validate the need before implementing. If this change does not apply to this SDK, please close the issue with a short note explaining why.


SDK Parity: C# implementation needed

A defensive fix was made in supabase-js auth that may apply to this repository. Please confirm applicability before starting work.

Reference Implementation (supabase-js)

  • Commit: 0c227a1
  • PR: supabase/supabase-js#2336
  • Module: auth
  • Type: bug-fix (resilience)
What Changed

Session-storage reader returns null on JSON parse failure, treating corrupted entries as absent rather than crashing downstream.

Implementation Guidance (C#)

private Session? ReadSessionFromStorage()
{
    var raw = _storage.GetItem(_storageKey);
    if (raw == null) return null;
    try
    {
        return JsonSerializer.Deserialize<Session>(raw);
    }
    catch (JsonException)
    {
        return null; // Corrupted — treat as no session
    }
}
Key Behaviors to Match
  • Invalid JSON in session storage → null, not exception

Acceptance Criteria

  • Corrupted session storage returns null, not throws
  • Test verifies the behavior

Context

  • supabase-js version: v2.106.0
  • Related: SDK-1038 (dart), SDK-1039 (py), SDK-1040 (swift)
  • Parity tracking: Auto-generated by /sync-sdk-parity
Dominant language
C#
Stars
701
Forks
106
Avg merge
16h 35m
Merged PRs (30d)
45

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from supabase/supabase-csharp

All issues in supabase/supabase-csharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.