Dive Planner custom SAC per dive segment.

Open
#3,928 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
desktop

Research direction

No files or tests are named. Start by locating the dive planner point table and the existing general and per-leg SAC handling, then determine how a segment-specific value would affect planning calculations. Done means each dive leg can use its own SAC while defaulting to the general bottom SAC.

Written by the indexing model from the issue text.

Description

Describe the issue:
  • Bug
  • Change request
  • [ x] New feature request
  • [ x] Discussion request
Issue long description:

Wile planning a dive ususally we know our SAC, it is totally different while fighting a current or making some work, than when relaxed making a deco stop holding a line for example. My suggestion is to create a SAC field in the dive planner point table that will by default place the bottom SAC placed on the general field. But that can be manually changed for that specific leg to whatever value we want. This would make the planer so much better.

Operating system:

All Operating systems.

Current behavior:

Only Two possible SAC values are assigned for all the dive legs.

Expected behavior:

Be able to assign different SAC values for different legs.

Dominant language
C++
Stars
3.2k
Forks
601
Avg merge
2d 22h
Merged PRs (30d)
29

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from subsurface/subsurface

All issues in subsurface/subsurface

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.