"git stack list" shows all commit in the repo

Open
#7 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
git, github, python
Domain
cli, devtools

Research direction

Reproduce the behavior from the issue by running git stack list on the described stacked branch, then trace the command's stack-boundary detection. Done means the list stops at the stack base rather than showing the repository's full history, and git stack pr --all does not include unrelated commits.

Written by the indexing model from the issue text.

Description

First of all, much thanks for this tool! It warms my heart to see a free to use PR stacking tool out there.

I currently have this stack:

commit 78807ddaebc1134b9035dc30b2c171dedff23ff8 (HEAD -> ahmet/misc-refactoring-4)
...
    prev-branch: ahmet/misc-refactoring-3


commit 184725a1c420dbed31e73b15a7de77f9fc84aa43 (ahmet/misc-refactoring-3)
...
    prev-branch: ahmet/misc-refactoring-2


commit a2f6e3521695bd246aa5c83bf0c97d8cff333849 (ahmet/misc-refactoring-2)
...
    prev-branch: ahmet/misc-refactoring-1


commit b5c7be93b7b2f9ac149cae2cb60131e85d7f656c (origin/ahmet/misc-refactoring, ahmet/misc-refactoring-1, ahmet/misc-refactoring)

When I'm on branch ahmet/misc-refactoring-4 (tip) and run git stack list, I get the entire commit tree all the way down to the initial commit. It seems for whatever reason the tool is not detecting where the stacking begins.

$ git stack list
  * 78807dd 11 minutes (HEAD, ahmet/misc-refactoring-4) <commitmsg>
  * 184725a 39 minutes (ahmet/misc-refactoring-3) <commitmsg>
  * a2f6e35 49 minutes (ahmet/misc-refactoring-2) <commitmsg>
  * b5c7be9 69 minutes (ahmet/misc-refactoring-1) <commitmsg>
 /
* 12c1728 5 hours (tag: v0.0.566, master) <commitmsg>
* | * 1c6fb9e 10 hours (ahmet/anotherbranch) <commitmsg>
* |/

I'm very scared of running git stack pr --all because it might create hundreds of PRs. 😬

Any ideas what might be going on here?

Dominant language
Python
Stars
17
Forks
1
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stevearc/gitstack

All issues in stevearc/gitstack

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.