stdlib-js / stdlib-js/stdlib

Address commit comments (commit `ad7a023`)

Aperta
#5,901 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Good First Issue
Lingua principale
JavaScript
Stelle
6k
Fork
1.3k
Merge medio
1g 3h
PR unite (30g)
611

Descrizione

This commit has **2** comment(s) from core contributors that require attention.

**Commit:** [ad7a02395bbac49b3049917fdc82c1c1c9dae08b](https://github.com/stdlib-js/stdlib/commit/ad7a02395bbac49b3049917fdc82c1c1c9dae08b)

**Comments:**

- https://github.com/stdlib-js/stdlib/commit/ad7a02395bbac49b3049917fdc82c1c1c9dae08b#r153448809

> **Line 45**: @stdlib-bot L45-46 should be refactored to use `random/base/uniform` as in other packages and benchmarks.

https://github.com/stdlib-js/stdlib/blob/ad7a02395bbac49b3049917fdc82c1c1c9dae08b/lib/node_modules/@stdlib/stats/base/dists/levy/variance/benchmark/benchmark.js#L42-L48

- https://github.com/stdlib-js/stdlib/commit/ad7a02395bbac49b3049917fdc82c1c1c9dae08b#r153448812

> **Line 54**: @stdlib-bot L54-55 should be refactored to use `random/base/uniform` as in other packages and benchmarks.

https://github.com/stdlib-js/stdlib/blob/ad7a02395bbac49b3049917fdc82c1c1c9dae08b/lib/node_modules/@stdlib/stats/base/dists/levy/variance/benchmark/benchmark.native.js#L51-L57

Interested in helping improve the project? If you are, the comment linked to above has **2** comment(s) from core contributors that could use your attention.

What do you need to do?

1. Open the above linked comments mentioning @stdlib-bot.
2. Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
3. If you are a first-time contributor, follow the [contributing](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md) and [development](https://github.com/stdlib-js/stdlib/blob/develop/docs/development.md) guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
4. Make all the desired changes and commit those changes to a local branch.
5. Push the changes to GitHub and open a new pull request against the `develop` branch of the main stdlib development [repository](https://github.com/stdlib-js/stdlib).

Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.

And that's it!

Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌

* * *

## Notes

- For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!

* * *

This issue was created automatically to address commit comments tagging @stdlib-bot.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.