stdlib-js / stdlib-js/stdlib

[RFC]: Refactor random number generation in JS benchmarks for `stats/base/dists/rayleigh`

Aperta
#4,985 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Benchmarks difficulty: 1 Good First Issue JavaScript RFC
Lingua principale
JavaScript
Stelle
6k
Fork
1.3k
Merge medio
1g 3h
PR unite (30g)
611

Descrizione

### Description

This RFC proposes improving random number generation in JS benchmarks for [`stats/base/dists/rayleigh`](https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/base/dists/rayleigh).

**Context**: At present, in the remaining packages, random number generation in JS benchmarks occurs inside the benchmarking loop. Since random number generation is an expensive operation, it should be moved out of the benchmarking loops and initialized beforehand to avoid interfering with the results.

When adding support, the following tasks should be completed:

1. Move random number generation out of the benchmarking loops and initialize it before the benchmarks.

2. Ensure that the generated random values use the same range as the existing values to maintain consistency.

3. Use `uniform` and `discreteUniform` from `@stdlib/random/base/uniform` and `@stdlib/random/base/discrete-uniform` instead of `randu` expressions.
- For example, replace `( randu() * 10.0 + EPS )` with `uniform( EPS, 10.0 )`.
- Replace `ceil( randu() * 10.0 + EPS )` with `discreteUniform( 1, 10 )`.

To provide a concrete example of what a PR implementing the desired changes should contain, see #4837 and #4955, which provide examples for using both `uniform` and `discreteUniform`.

### Related Issues

#4837, #4955

### Questions

No.

### Other

Once the implementation is complete, you should be able to run the following `make` commands:

#### Build Native Add-on
```sh
NODE_ADDONS_PATTERN="@stdlib/stats/base/dists/rayleigh/*" make install-node-addons
```

#### Run JavaScript Benchmarks
```sh
make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/rayleigh/*/benchmark/benchmark.js"
```

#### Run JavaScript Native Benchmarks
```sh
make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/rayleigh/*/benchmark/benchmark.native.js"
```

**Note:** If running benchmarks results in an error, it is likely due to the random number generators producing values where the functions are not defined. To resolve this, check the relevant benchmark files, adjust the input value ranges to ensure they remain within the domain where the functions are valid, and then rerun the benchmarks. Reference: [#4955](https://github.com/stdlib-js/stdlib/pull/4955#issuecomment-2622578367)

### Checklist

- [x] I have read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [x] Searched for existing issues and pull requests.
- [x] The issue name begins with `RFC:`.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.