stdlib-js / stdlib-js/stdlib

[RFC]: refactor `blas/ext/base/dsort2sh` to follow current project conventions

未关闭
#1,497 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Good First Issue JavaScript Native Addons priority: High
主要语言
JavaScript
星标
6k
派生
1.3k
平均合并
1 天 3 小时
30 天内合并 PR
611

描述

### Description

This RFC proposes refactoring [`@stdlib/blas/ext/base/dsort2sh`](https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/blas/ext/base/dsort2sh) to follow current project conventions.

These conventions are outlined in more detail in https://github.com/stdlib-js/stdlib/issues/788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include https://github.com/stdlib-js/stdlib/commit/d66d80cfcbab1da95cb5ae8cfae4a1fc4c5129d1 (saxpy), https://github.com/stdlib-js/stdlib/commit/3c82fe7b6c0f9fd6ef02c86d6e2024d708ac8c14 (cswap), and https://github.com/stdlib-js/stdlib/commit/5b15c9675be434c0e11b1ec1e1f78d7b089abbcd (dasum).

### Related Issues

Related issues #788, #1152.

### Questions

No.

### Other

No.

### Checklist

- [X] I have read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [X] Searched for existing issues and pull requests.
- [X] The issue name begins with `RFC:`.

贡献指南

打开贡献指南

调研方向

Start in lib/node_modules/@stdlib/blas/ext/base/dsort2sh and compare its implementation with the conventions in issue #788 and the saxpy, cswap, and dasum example commits. Review the C++ add-on interface and the requested C interface migration, then confirm the module and its tests follow the current style and remain functional.

由索引模型根据 Issue 内容生成。

评估

技术栈
c, cpp, javascript
领域
backend
Issue 类型
重构
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。