[RFC]: Improve sorted arrays generation in C benchmarks for sorted-input packages
- 主要语言
- JavaScript
- 星标
- 6k
- 派生
- 1.3k
- 平均合并
- 1 天 3 小时
- 30 天内合并 PR
- 611
描述
### Description
This RFC proposes to generalize the generation of random arrays in C benchmarks for sorted-input packages. It mainly tries to add a random factor for the generated values and make use of the already existing `rand_double()` function and `time.h` header for consistency between packages.
For example, for double precision packages, to be changed from: (e.g., from `stats/base/strided/dminsorted`)
```C
x = (double *) malloc( len * sizeof( double ) );
for ( i = 0; i < len; i++ ) {
x[ i ] = i;
}
```
To:
```C
x = (double *) malloc( len * sizeof( double ) );
for ( i = 0; i < len; i++ ) {
x[ i ] = (double)i + rand_double();
}
```
Packages that are directly affected by this (add more if found):
- [ ] `stats/strided/dmediansorted`
- [ ] `stats/strided/dmaxsorted`
- [ ] `stats/strided/dminsorted`
- [ ] `stats/strided/smediansorted`
- [ ] `stats/strided/smaxsorted`
- [ ] `stats/strided/sminsorted`
### Related Issues
None.
### Questions
#### Question 1
I suggest that we either enforce this or refactor the already existing packages that don't use any randomness by removing the `time.h` header and `rand_double()` function since they're not used anywhere in the benchmark.
#### Question 2
What about the absolute sorted-input packages? Current approach is: (from `stats/base/strided/dmaxabssorted`)
```C
x = (double *) malloc( len * sizeof( double ) );
for ( i = 0; i < len; i++ ) {
x[ i ] = i - (len/2);
}
```
### Other
No.
### Checklist
- [x] I have read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [x] Searched for existing issues and pull requests.
- [x] The issue name begins with `RFC:`.
贡献指南
调研方向
首先检查列出的 stats/strided/*sorted 基准测试包,尤其是 dmediansorted、dmaxsorted、dminsorted、smediansorted、smaxsorted 和 sminsorted,并检查其中现有的 rand_double() 和 time.h 使用情况。确定是否包含绝对排序输入包;完成的标准是,在受影响的基准测试中一致地应用约定的生成方法,或移除未使用的随机性支持。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- c
- 领域
- performance
- Issue 类型
- 重构
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100