stackabletech / stackabletech/stackablectl

Nix pre-commit and ci checks

Open
#298 2 comments 0 reactions 1 assignee View on GitHub

@NickLarsenNZ is already working on this.

Since Jun 5, 2024.

Dominant language
Rust
Stars
10
Forks
5
Avg merge
4h 41m
Merged PRs (30d)
4

Description

Currently, the nix lock files (for crate2nix and for the packages via niv) are only updated when one of the Nix users runs:

  • make regenerate-nix, and
  • niv update

This means that dependencies in Cargo.lock and Cargo.nix might be at different versions.

To resolve this, we can:

  • Add the update commands to the pre-commit hooks, and/or
  • Run the commands in CI and check for changes

Optionally, perhaps make regenerate-nix could also do the niv update so there is one command.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.