SftpClient Thread leak when authentication fails

Using 2016.1.0

As the title says, when attempting to call Connect(), if the connection succeeds but the authentication fails, a leak happens. This can be negated by wrapping the connection in a Try/Catch and calling Disconnect if the call throws.

Here's a simple loop producing the effect (remove the Disconnect to see the increase in thread count) :

class Program
{
    static void Main(string[] args)
    {
        var testCount = 10;
        var clientInstance = new SftpClient("127.0.0.1", 22, "username", "invalidpassword");
        var process = Process.GetCurrentProcess();

        var threadCountBefore = process.Threads.Count;

        for (var i = 0; i < testCount; i++)
        {
            try
            {
                clientInstance.Connect();
            }
            catch
            {
                // Without this, there is a thread leak
                clientInstance.Disconnect();
            }
        }

        process.Refresh();
        var threadCountAfter = process.Threads.Count;
    }
}

After some research, I believe it is linked to the message listener thread in Session.cs. After starting it, if the key exchange fails, the code will gracefully exit by calling Disconnect() first. Otherwise, it goes on to authentication but allows the exceptions to break the flow and exit immediately, without calling Disconnect().

Inizia in Session.cs e riproduci il problema con il ciclo Connect() fornito usando credenziali non valide. Traccia il percorso del fallimento dell’autenticazione dopo l’avvio del thread del listener dei messaggi, confrontandolo con il percorso del fallimento dello scambio di chiavi. Il lavoro è completato quando tentativi ripetuti di autenticazione non riusciti non causano più perdite di thread senza richiedere un Disconnect() esplicito.