Allow ViewEnvironment (esp ViewRegistry) to support merging values

Open
#135 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
kotlin, swift
Domain
mobile-dev

Research direction

Start by tracing ViewEnvironment and ViewRegistry, then examine how envA + envB currently handles the registry. Define the general merge behavior and make ViewRegistry use it; done means combining environments no longer replaces ViewRegistry entirely.

Written by the indexing model from the issue text.

Description

enhancement kotlin swift

In kotlin, it's surprising that that envA + envB stomps A's ViewRegistry entirely. It's not hard to work around, but it's tedious.

We should think about providing a general mechanism to allow entries to merge, and make ViewRegistry use it.

Dominant language
Swift
Stars
373
Forks
46
Avg merge
6h 38m
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from square/workflow-swift

All issues in square/workflow-swift

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.