simvue-io / simvue-io/python-api
Support for storage system of type `file` broken
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4
- Forks
- 1
- Avg merge
- 5d 8h
- Merged PRs (30d)
- 4
Description
In simvue/factory/proxy/remote.py it tries to upload a file if url is in the JSON response to the POST to /api/artifacts. However, for the case of a storage system of type file, where you just store references to files, the client shouldn't try to upload a file.
If the url is None the upload shouldn't be attempted. Currently the client tries to upload a file to None which fails of course.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in simvue/factory/proxy/remote.py and trace the response from the POST to /api/artifacts. Verify the file-upload path only runs when the returned url is not None; for a file storage system with a None url, done means no upload is attempted and the artifact reference is retained.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100