simplesamlphp / simplesamlphp/simplesamlphp-module-oidc
We always throw if `id_token_hint` is missing when `post_logout_redirect_uri` is used
还没有人认领这个 Issue。
- 主要语言
- PHP
- 星标
- 50
- 派生
- 28
- 平均合并
- 1 分钟
- 30 天内合并 PR
- 2
描述
The spec RP-Initiated Logout https://openid.net/specs/openid-connect-rpinitiated-1_0.html says:
- Redirection to RP After Logout
In some cases, the RP will request that the End-User's User Agent to be redirected back to the RP after a logout has been performed. Post-logout redirection is only done when the logout is RP-initiated, in which case the redirection target is the post_logout_redirect_uri parameter value sent by the initiating RP. An id_token_hint carring an ID Token for the RP is also RECOMMENDED when requesting post-logout redirection; if it is not supplied with post_logout_redirect_uri, the OP MUST NOT perform post-logout redirection unless the OP has other means of confirming the legitimacy of the post-logout redirection target. The OP also MUST NOT perform post-logout redirection if the post_logout_redirect_uri value supplied does not exactly match one of the previously registered post_logout_redirect_uris values. The post-logout redirection is performed after the OP has finished notifying the RPs that logged in with the OP for that End-User that they are to log out the End-User.
Currently we always throw, that is, stop the execution when id_token_hint is missing when post_logout_redirect_uri is used: https://github.com/simplesamlphp/simplesamlphp-module-oidc/blob/4c254afa8a80eb869351bc6dc161479f1f4d54a2/src/Server/RequestRules/Rules/PostLogoutRedirectUriRule.php#L59
Reading the spec, since id_token_hint is RECOMMENDED, we should not stop the execution, but simply not redirect to the post_logout_redirect_uri. We could show our own "you are logged out" page instead.
- TODO mivanci check how conformance tests handle this situation
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从链接的规则处开始查看 src/Server/RequestRules/Rules/PostLogoutRedirectUriRule.php,并阅读 RP-Initiated Logout 规范中关于注销后重定向的章节。按照 TODO 中的说明,检查 conformance tests 如何处理缺少 id_token_hint 的情况。完成的标准是:请求不会仅因缺少 hint 而被停止,并且除非规范允许,否则不会执行注销后重定向。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- php
- 领域
- authentication
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 55/100