simplesamlphp / simplesamlphp/simplesamlphp-module-discopower

Symlinks don't install correctly when Composer falls back on the PHP zip library

未关闭
#28 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
PHP
星标
5
派生
11
PR 合并指标
30 天内没有已合并 PR

描述

I couldn't figure out why the Discopower module wasn't installing correctly inside my Docker image of SSP. The symlinks under modules/discopower/public/assets/components were being installed as text files containing the path where they would have pointed had they been symlinks. This obviously didn't work so great when my browser tried to load the Jquery Javascript for Discopower.

After further investigation, I tried installing unzip into my Docker image before running composer, and that fixed it. I now have symlinks instead of text files. Clearly, the PHP zip library doesn't understand symlinks.

If possible, installation of this module should require that the unzip or 7z binary be installed on the system and not just the PHP zip library.

If that's not possible, the documentation should at least include this requirement for proper installation.

Ideally, these symlinks wouldn't be necessary, and the disco.twig code that loads these components would point to the files directly instead of the symlinks inside of the module.

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先,在所述的 Docker 设置中复现 Composer 安装,并将 PHP 的 zip 库与 unzip 或 7z 进行比较。检查 modules/discopower/public/assets/components 以及加载这些 assets 的 disco.twig 代码。当安装行为或文档中的系统要求明确处理 symlinks 时,即视为完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
php
领域
build-system
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
需要澄清
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。