shipshapecode / shipshapecode/angular-shepherd
Add `attributes` on `StepOptionsButton`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 238
- Forks
- 50
- Avg merge
- 1m
- Merged PRs (30d)
- 9
Description
Hello !
I would like to be able to add a data-testid attribute on the generated buttons for the tour, in order to ease the E2E tests of my application.
My code would look like
const steps: Step.StepOptions[] = [
{
id: TourService.STEP_0_WELCOME,
text: `<h1>Welcome !</h1>
<div>Let us take you on a quick tour.</div>`,
buttons: [
{
classes: 'tour-button-secondary',
text: 'Skip tutorial',
attributes: {'data-testid', 'tutorial-button-skip'},
action: skip,
},
{
classes: 'tour-button-primary',
text: 'Next',
attributes: {'data-testid', 'tutorial-button-next'},
action: next,
},
],
},
}
Do you think this is a feature you could add ?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the StepOptionsButton entry point and tracing how tour buttons are generated. Verify how the requested attributes option should be represented, then confirm that a data-testid supplied in a step appears on the generated button and that existing button behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100