Follow-up: accept passive independently owned route blockers after #409
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 70/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- ruby
- Domain
- testing-qa, tooling
Research direction
Start with forbidden_route_only_contradiction? and the existing routing contract in skills/pr-batch/bin/model-routing-contract-test.rb; reproduce the passive blocker case on the referenced merged commit. Add the regression mutant and positive controls while preserving the stated routing behaviors, then run AGENT_WORKFLOWS_SOURCE_CHECKOUT=1 ruby skills/pr-batch/bin/model-routing-contract-test.rb and bin/validate; done includes reconciling the original PR #409 thread.
Written by the indexing model from the issue text.
Description
Problem
PR #409 merged advisory-routing mutation coverage, but the merged contradiction detector still rejects a policy-compliant passive independent-blocker sentence:
A route mismatch occurs, but launch is blocked by a credential check.
forbidden_route_only_contradiction? returns true. The detector recognizes active independent ownership such as “a credential check blocks launch,” but not the passive form “launch is blocked by a credential check.” It therefore incorrectly attributes the blocked launch to the route mismatch.
This was reported before merge in https://github.com/shakacode/agent-workflows/pull/409#discussion_r3848708964 and remained unresolved when PR #409 merged.
Expected behavior
- Accept passive independently owned blocker clauses where the blocking owner is an existing independent risk, scope, evidence, authority, credential, or security gate.
- Continue rejecting unconditional route-only stops.
- Preserve negation, fence/comment, paragraph-boundary, and same-sentence ownership behavior already covered by the routing contract.
Acceptance criteria
- Add a direct regression mutant for the sentence above.
- Add nearby positive controls proving a route mismatch still cannot itself block launch.
- Run
AGENT_WORKFLOWS_SOURCE_CHECKOUT=1 ruby skills/pr-batch/bin/model-routing-contract-test.rbandbin/validate. - Reconcile and resolve the original PR #409 thread with the follow-up PR evidence.
Process Gap Disposition
- Mechanism target: script
- Motivating miss: PR #409 merged with an unresolved P2 thread and a reproducible false positive in the required routing contract.
- Replay evidence or park reason: run
forbidden_route_only_contradiction?againstA route mismatch occurs, but launch is blocked by a credential check.on merged commit42946dae47effeb549cf06fbdf2451e8bed705cb; it returnstrue. - Non-goal: replacing the bounded routing mutation detector with a general natural-language or CommonMark parsing framework.
- Dominant language
- Ruby
- Stars
- 7
- Forks
- 1
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 150
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from shakacode/agent-workflows
-
complexity:neutral follow-up P3 triage:park
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
shakacode/agent-workflows#751 ·
-
complexity:complexify follow-up needs-customer-feedback P3 review-nit triage:park
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
shakacode/agent-workflows#750 ·
-
complexity:neutral follow-up P2 triage:reconcile
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
shakacode/agent-workflows#640 ·
-
complexity:neutral P2 triage:reconcile
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
shakacode/agent-workflows#483 · 1 comment ·
-
complexity:complexify enhancement P2
Difficulty 5/5 Over a week Newbie friendliness 25/100
shakacode/agent-workflows#852 ·
All issues in shakacode/agent-workflows
Similar issues
-
バグ
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
voxpupuli/puppet-epel#186 · 1 comment ·
-
external_created_at is no longer used for the message timestamp since the new message UI (v4.4.0) OpenBug Frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
TheOdinProject/curriculum#31402 · 1 comment ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100