ruby-ui / ruby-ui/ruby_ui

`TooltipTrigger` emits a dead `variant="outline"` attribute

Open Beginner friendly
#542 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
1k
Forks
67
Avg merge
3d 12h
Merged PRs (30d)
14

Description

  • Where: tooltip_trigger.rb default attrs. Snapshot tooltip/default.
    Already listed in design/v2/01-research/golden-suite.md.
  • Effect: variant is not an HTML attribute and nothing in the CSS
    matches it (the data-[variant=…] selectors match data-variant); the
    outline look comes from the Button inside.
  • Fix: remove it; re-record (on the 2.0 line) tooltip/*.

Surfaced by the golden HTML suite (PR #536), which pins what 1.6 renders today — this defect included. Per maintainer decision (2026-09-19) main stays as is: this is addressed on the 2.0 line, and the golden snapshot that pins it is re-recorded there with the diff reviewed.

Source: design/v2/follow-up-issues.md.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in tooltip_trigger.rb at the default attrs and inspect the tooltip/default snapshot, then review design/v2/01-research/golden-suite.md. On the 2.0 line, remove the dead variant attribute and re-record the tooltip/* snapshots; done means the reviewed snapshot diff no longer contains that attribute.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
frontend, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.