Excess backslashes in Authorize URL

Open
#271 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
ruby
Domain
authentication, cli

Research direction

Start with the t authorize command and trace how it constructs the second Twitter app authorization URL. Reproduce the issue using the reported version details, then verify that the generated URL contains a single backslash before each \u0026 and opens the authorization page instead of an empty page.

Written by the indexing model from the issue text.

Description

bug

When running t authorize, first URL that the script opens ("Twitter Developer site") is OK, but the second one ("Twitter app authorization page") has excess backslashes--two backslashes before each &, eg.:

http://some/url?foo=bar\\&baz=quux

instead of

http://some/url?foo=bar&baz=quux

This of course invalidates the URL, causing empty page (not a 4xx error...). Removing the backslashes seems to fix the problem.

Version details:

$ t --version
2.9.0
$ rpm -q xfce4-terminal firefox bash
xfce4-terminal-0.6.3-3.fc21.x86_64
firefox-38.0.5-1.fc21.x86_64
bash-4.3.39-1.fc21.x86_64
$
Dominant language
Ruby
Stars
5.6k
Forks
402
Avg merge
13h 50m
Merged PRs (30d)
5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sferik/x-cli

All issues in sferik/x-cli

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.