scverse / scverse/spatialdata-plot

Custom title when multiple coordinate system present and no coordinate system specified

Abierto
#269 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

:speaking_head: discussion enhancement priority: medium
Lenguaje dominante
Python
Estrellas
86
Forks
21
Merge medio
14 h 50 min
PR fusionados (30 d)
3

Descripción

When there is a object with 2 coordinate systems and pl.show() is called without specifying coordinate_systems, by default two subplots are created. If the user adjust the title=, both titles are changed, leading to a plot that is confusing, especially if it was not clear that the object (or an element of the object) was aligned to multiple coordinate systems.

This is exactly what happened in the following plots (that appeared from a bug reported by a user).

before setting the title

Screenshot 2024-05-30 at 11 55 06

after setting the title

not sure why the order changes but no big deal, not the point of this issue
Screenshot 2024-05-30 at 11 55 11

solution for this case

Solution for the user: here the fix is to specify coordinate_systems='global', which will lead to a single plot.

proposed solution

Discussed also with @melorona. I proposed to change the default behavior as follows:

  • coordinate_systems will have a new default of None.
  • if the object has a single coordinate system and coordinate_system is None, this will be plotted
  • elif the object has multiple coordinate system and coordinate_system is None and one of them is called 'global' (defined in from spatialdata.models._utils import DEFAULT_COORDINATE_SYSTEM), this will be plotted
  • if coordinate_system is not None and coordinate_system is available, this will be plotted
  • else (i.e. if coordinate_system is None, multiple coordinate systems are present and none of them is called 'global', or if coordinate_system is not None and it's not available in the data, then an error will be raised, printing the list of available coordinate systems.

What will change for the user:

  • with this change, by default we won't plot multiple coordinate systems; if this is still the desired behavior, the user can still pass a list of coordinate systems.

Extra comments:

  • with the incoming "transformations refactoring" it will be required to specify which coordinate system to plot because elements will not contain an explicit list of coordinate systems they are aligned to but there will only be a big graph of transformations where a lot of coordinate systems can be aligned to a lot of other coordinate systems. So it will be important to plot only what the user asks for
  • in general, the current default behavior is useful when there are multiple FOVs for a dataset (like in the MIBITOF example dataset); but in other cases where there is the same data in multiple coordinate systems, like in Xenium, or where the number of FOVs is very large, like in CosMx, the currently implemented default behavior is suboptimal, and requiring the proposed new default would be handier.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza en el punto de entrada pl.show() y sigue cómo se seleccionan los valores predeterminados de coordinate_systems cuando un objeto tiene uno o varios sistemas de coordenadas. Se considera terminado cuando el valor predeterminado selecciona el único sistema o el sistema global, genera un error con los sistemas disponibles cuando no existe un valor predeterminado válido y sigue permitiendo que los llamadores pasen una lista explícitamente.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
data-visualization
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.