Fixes and follow-ups to two-sided broadcasting in arithmethic ops
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 20/100
Research direction
Start by reviewing the two-sided broadcasting changes in issue #898 and the arithmetic-operation code they introduced. Work through each unchecked follow-up—trait bounds, allocation preservation for Array + Array, and a possible public broadcasting API—and confirm the relevant behavior and API decisions before considering the issue complete.
Written by the indexing model from the issue text.
Description
In #898 we left the following "known issues" open that we can fix after that PR's review and merge:
- Rename BroadcastShape to
DimMax- we also move the broadcast method out of the trait (it can just be a free function) - It is a wish that the
D: Dimension + DimMax<E>bound in arith ops becomes justD: Dimension, i.e. the DimMax with associated type becomes implied byD: Dimension. At this point it is not certain how this can be done. - Preserve the allocation of the input array in arithmetic ops in more cases (when only the left/right side needs broadcast) in array + &array and &array + array
- Preserve the allocation of the input array in arithmetic ops in more cases (when the left side needs broadcast in Array + Array)
- Improve performance of "no-broadcasting-needed" scenario in &array + &array operation
- Potentially provide public function or method similar to
broadcast_with- that does the broadcasting of two arrays together.
- Dominant language
- Rust
- Stars
- 4.3k
- Forks
- 391
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rust-ndarray/ndarray
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
rust-ndarray/ndarray#1612 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
rust-ndarray/ndarray#1617 · 1 comment ·
-
bug good first issue
Difficulty 3/5 1-2 days Newbie friendliness 68/100
rust-ndarray/ndarray#1615 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
rust-ndarray/ndarray#1610 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
rust-ndarray/ndarray#1609 ·
All issues in rust-ndarray/ndarray
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
kwakseongjae/auto-hwp#319 ·
-
area:cli bug filter-quality good first issue priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
bevyengine/bevy#25861 ·
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
enhancement remote
Difficulty 2/5 1-3 hours Newbie friendliness 68/100