Link carries type="button" on an <a>

Open
#553 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
html, ruby
Domain
frontend, testing

Research direction

On the 2.0 line, inspect link.rb and its default_attrs, then review the link/* snapshots. Run the strict golden HTML suite or the relevant link snapshot tests first. Done means the anchor no longer includes type="button" and the affected snapshots are re-recorded with the diff reviewed.

Written by the indexing model from the issue text.

Description

bug
  • Where: link.rb default_attrs {type: "button", ...}, copied from Button. Snapshots link/*.
  • Effect: type on an anchor names the linked resource's MIME type; button is meaningless there. Invalid, harmless.
  • Fix: drop type: from Link's default_attrs; re-record link/*.

Surfaced by the strict lane of the golden HTML suite (PR #548), which pins what 1.6 renders today — this defect included. Per maintainer decision (2026-09-19) main stays as is: this is addressed on the 2.0 line, and the golden snapshots that pin it are re-recorded there with the diff reviewed.

Source: design/v2/follow-up-issues.md.

Dominant language
Ruby
Stars
1k
Forks
67
Avg merge
2d 19h
Merged PRs (30d)
18

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ruby-ui/ruby_ui

All issues in ruby-ui/ruby_ui

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.