DataTable nests `<form>` inside `<form>`
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1k
- Forks
- 67
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 14
Description
- Where:
DataTableFormwraps the table;DataTableSearchand
DataTablePerPageSelecteach render their own<form>inside it.
Snapshotdata_table/full_frameholds three<formelements. - Effect: nested forms are invalid HTML. A browser ignores the inner
<form>start tags when a form is in scope, so the search input and the
per-page select become children of the outer bulk form, and
this.form.requestSubmit()indata_table_search_controller.jssubmits
the wrong form. - Fix: render the search and per-page forms outside the bulk form, or
make their controls reference it with theform=attribute; re-record (on the 2.0 line)
data_table/*. - 2.0 note: Herb's
NestingValidatorwill likely reject this at compile
time, which makes it a template adjustment in the DataTable migration.
Fixing it on 1.6 first keeps the migration a pure port.
Surfaced by the golden HTML suite (PR #536), which pins what 1.6 renders today — this defect included. Per maintainer decision (2026-09-19) main stays as is: this is addressed on the 2.0 line, and the golden snapshot that pins it is re-recorded there with the diff reviewed.
Source: design/v2/follow-up-issues.md.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with DataTableForm, DataTableSearch, DataTablePerPageSelect, and data_table_search_controller.js, then inspect the data_table/full_frame snapshot and the other data_table snapshots. Confirm the rendered form structure and how requestSubmit() selects its target. Done means the 2.0 templates avoid nested forms and the data_table/* snapshots are re-recorded and reviewed with the corrected output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, ruby
- Domain
- frontend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100