ruby-i18n / ruby-i18n/ruby-cldr

Distinguishing attribute `numberSystem` is ignored.

Open
#79 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
78
Forks
18
Avg merge
9d 8h
Merged PRs (30d)
3

Description

Cldr::Export::Data::Numbers#symbols ignores the distinguishing attribute numberSystem:

Example

In the bn locale, there are data for two number systems. However, Cldr::Export::Data::Numbers#symbols merges them all together:

(byebug) select('numbers/symbols/*').size
23

23 = 11 from the beng numberSystem, and 12 from the latn numberSystem (CLDR v34)

The result is a set of symbols that combine bits of both numberSystems.

bn:
  numbers:
    symbols:
      alias: ''
      decimal: "."
      group: ","
      list: ";"
      percent_sign: "%"
      plus_sign: "+"
      minus_sign: "-"
      exponential: E
      superscripting_exponent: "×"
      per_mille: "‰"
      infinity: "∞"
      nan: NaN
      time_separator: ":"

Distinguishing attributes are used to distinguish multiple elements at the same level.

I expected different numberSystem elements to be kept separate during the export, since that's what the spec calls for. Something like:

bn:
  numbers:
    symbols:
      beng:
          ....
      latn:
          ....

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Cldr::Export::Data::Numbers#symbols and compare its output for the bn locale against the CLDR numberSystem distinction described in the issue. The work is complete when beng and latn symbols remain separate in the exported YAML instead of being merged.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
localization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.