ruby-concurrency / ruby-concurrency/concurrent-ruby
`Concurrent::Hash` default initialization is not fully thread-safe
@eregon 已经在做这个了。
开始于 2022年12月12日。
- 主要语言
- Ruby
- 星标
- 5.8k
- 派生
- 420
- 平均合并
- 20 小时 45 分钟
- 30 天内合并 PR
- 4
描述
Based on the docs:
A thread-safe subclass of Hash. This version locks against the object itself for every method call, ensuring only one thread can be reading or writing at a time. This includes iteration methods like #each, which takes the lock repeatedly when reading an item.
Given this code:
h = Concurrent::Hash.new do |hash, key|
hash[key] = Concurrent::Array.new
end
the initialization is not thread-safe.
Note from @eregon, the thread-safe variant of this code is:
h = Concurrent::Map.new do |hash, key|
hash.compute_if_absent(key) { Concurrent::Array.new }
end
Obviously the latter part of the doc indicates that:
ensuring only one thread can be reading or writing at a time
but the initial part makes it confusing:
This version locks against the object itself for every method call
It can be demoed by running this code:
require 'concurrent-ruby'
1000.times do
h = Concurrent::Hash.new do |hash, key|
hash[key] = Concurrent::Array.new
end
100.times.map do
Thread.new do
h[:na] << true
end
end.each(&:join)
raise if h[:na].count != 100
end
I would expect to either:
- Have the initialization block behind a mutex - so there is no conflict
- Have the docs updated (I can do that)
Works like so:
require 'concurrent-ruby'
m = Mutex.new
1000.times do
h = Concurrent::Hash.new do |hash, key|
m.synchronize do
break hash[key] if hash.key?(key)
hash[key] = Concurrent::Array.new
end
end
100.times.map do
Thread.new do
h[:na] << true
end
end.each(&:join)
raise if h[:na].count != 100
end
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。