Deadlock in Concurrent::Array's on non-MRI
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start with the linked gist and the Concurrent::Array documentation, then reproduce the behavior on MRI, JRuby, Rubinius, and TruffleRuby. Compare block-taking methods on Concurrent::Array and Concurrent::Hash; done requires a maintainer decision on intended locking semantics and whether behavior should be consistent across implementations.
Written by the indexing model from the issue text.
Description
concurrent-rubyversion: 1.0.4concurrent-ruby-extinstalled: noconcurrent-ruby-edgeused: no
Take the following code: https://gist.github.com/eregon/323890bfff539f8a33f66d8b2f02cc99
Of course, its purpose is to create a deadlock but it means any method taking a block on Array can cause a deadlock as long as:
- 2+ threads use 2+
Concurrent::Arrayby calling a method taking a block - inside the blocks, the threads call any method taking on another
Concurrent::Array
This seems not such a rare scenario, as it is frequent to call methods in a block that do not only involve the current Array.
The deadlock does not happen on MRI, as it uses a single global lock and concurrent-ruby just subclasses ::Array. It does happen on all other implementations though, like JRuby, Rubinius and TruffleRuby.
The documentation says:
A thread-safe subclass of Array.
This version locks against the object itself for every method call,
ensuring only one thread can be reading or writing at a time.
This includes iteration methods like #each.
So indeed this might imply the deadlock above, but it's not clear.
ensuring only one thread can be reading or writing at a time is also inaccurate on MRI for methods taking a block, as they release the GIL and might switch to another Thread in the middle of e.g. #each.
The same apply for Hash.
Is this behavior intended? Should this be fixed?
Should it behave the same on the different implementations?
- Dominant language
- Ruby
- Stars
- 5.8k
- Forks
- 420
- Avg merge
- 20h 45m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ruby-concurrency/concurrent-ruby
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
ruby-concurrency/concurrent-ruby#1118 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ruby-concurrency/concurrent-ruby#1099 · 9 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ruby-concurrency/concurrent-ruby#1095 · 8 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ruby-concurrency/concurrent-ruby#1093 · 3 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
ruby-concurrency/concurrent-ruby#1091 ·
All issues in ruby-concurrency/concurrent-ruby
Similar issues
-
バグ
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
voxpupuli/puppet-epel#186 · 1 comment ·
-
external_created_at is no longer used for the message timestamp since the new message UI (v4.4.0) OpenBug Frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
TheOdinProject/curriculum#31402 · 1 comment ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100