ruby-concurrency / ruby-concurrency/concurrent-ruby
Add API to prestart threads in threadpools
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Ruby
- Sterne
- 5.8k
- Forks
- 420
- Ø Merge
- 20 Std. 45 Min.
- Gemergte PRs (30 T.)
- 4
Beschreibung
For my use case I would like to ensure that when I create a thread pool with min_threads > 0, that the minimum number of workers are created immediately.
The Java interface for ThreadPoolExecutor calls this "prestart". For example: prestartCoreThread and prestartAllCoreThreads: https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadPoolExecutor.html#prestartCoreThread--
I have a draft PR (here) that implements a similar API for the CRuby implementation (I left the JRuby implementation for later). It adds both methods, as well as a prestart option to the initializer.
Is this an API change you would consider accepting?
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Start by reviewing the draft PR linked in the issue, especially its CRuby implementation, and compare the proposed API with the existing JRuby thread-pool implementation. No files or tests are named in the issue. Done means the prestart API and initializer option have an agreed design and supported implementations for the relevant runtimes.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- ruby
- Bereich
- backend, distributed-systems
- Issue-Typ
- Feature
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100