tagAppendAttributes()'s .cssSelector doesn't match top-level tag
@schloerke is already working on this.
Since Apr 14, 2023.
Assessment
This issue has not been assessed yet.
Description
I'd expect this to add the (bar = "BAR") attribute, but it currently doesn't:
tagAppendAttributes(div(class = "foo"), .cssSelector = ".foo", bar = "BAR")
#> <div class="foo"></div>
The reason why this doesn't work is that tagQuery() is only able to $find() children of the input tag
tagQuery(div(class = "foo"))$find(".foo")
#> `$allTags()`:
#> <div class="foo"></div>
#> `$selectedTags()`: (Empty selection)
Maybe it would make sense for tagAppendAttributes() to wrap the input up into a "dummy" tag (cc @schloerke)?
- Dominant language
- R
- Stars
- 225
- Forks
- 73
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rstudio/htmltools
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
Consider removing empty `.shiny-html-output` containers from document flow in fillable containers Open
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
All issues in rstudio/htmltools
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·