Accept objects of class package_version, numeric_version for dep version

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
web-dev

Research direction

Start by locating the HTML dependency version comparison and inspect how results from packageVersion("foo") are handled. Done means package_version and numeric_version values are accepted as dependency versions without an error at comparison time, while existing version handling continues to work.

Written by the indexing model from the issue text.

Description

Currently passing the result of packageVersion("foo") as an HTML dependency's version number causes an error at compare time. Consider allowing these by casting them to character.

Dominant language
R
Stars
225
Forks
73
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rstudio/htmltools

All issues in rstudio/htmltools

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.