add overwrite argument in `copyDependencyToDir` for Rmd `self_contained: false`
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Start by locating the copyDependencyToDir implementation and reading how it currently handles existing HTML dependencies and its mustWork argument. Add the proposed optional overwrite_dir behavior while preserving the current default, then verify repeated renders with self_contained: false avoid unnecessary overwrites.
Written by the indexing model from the issue text.
Description
Hi all,
I recently posted an issue in https://github.com/rstudio/rmarkdown/issues/2226#issue-1012707759 related to rmarkdown's self_contained: false yaml option. This option uses htmltools::copyDependencyToDir for HTML dependencies and it works great!
However, the current behavior of copyDependencyToDir is to overwrite HTML dependencies, even if they already exist, which can be time-consuming if you are iteratively rendering many Rmd files, and/or editing Rmd files using this option.
I'm happy to submit a PR, but wanted to post here to see if there were any concerns with adding in something like:
overwrite_dir = TRUE
copyDependencyToDir(
dependency,
outputDir,
mustWork = TRUE,
overwrite_dir = TRUE
)
- Dominant language
- R
- Stars
- 225
- Forks
- 73
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rstudio/htmltools
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
Consider removing empty `.shiny-html-output` containers from document flow in fillable containers Open
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
All issues in rstudio/htmltools
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·