Low priority: some HTML tags should not be closed

Open
#195 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
r
Domain
web-dev

Research direction

Start at the htmltools::tags$meta entry point and inspect how HTML tags are rendered, then find the existing tests for generated tags. Verify the behavior for meta, br, link, and input, and consider the work done when those tags render without a closing slash while other tags retain their current behavior.

Written by the indexing model from the issue text.

Description

There are some HTML tags that are not closed by convention. They are allowed to be closed for backwards compatibility with XHTML, but in practice these days they never have a closing slash.

These tags are the ones I know about: meta br link input

For example, the following code

htmltools::tags$meta(name="foo", content="bar")

Currently generates <meta name="foo" content="bar"/> but it should be <meta name="foo" content="bar">

Dominant language
R
Stars
225
Forks
73
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rstudio/htmltools

All issues in rstudio/htmltools

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.