Test fails due to rr hang

Open
#3,535 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp
Domain
devtools

Research direction

Start with the test hanging in Task::read_bytes_fallible and inspect the workaround around the zero-read, zero-errno condition. Compare the behavior with and without the condition and review the changes from #3436. Done means the affected tests no longer hang and their coverage still behaves as expected.

Written by the indexing model from the issue text.

Description

Some test hang in "Task::read_bytes_fallible" for me.

This is due to the workaround running indefinitely:

   if (0 == nread && 0 == all_read && 0 == errno) {
   ...
      continue;
    }

With a condition to only check this one, the tests work fine.

I also applied #3436 which could contribute to the whole behavior.

But I don't know if the test coverage still works as expected with the changes.

Dominant language
C++
Stars
10.7k
Forks
662
Avg merge
2d 3h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rr-debugger/rr

All issues in rr-debugger/rr

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.