adjusted_counting_period assertion failures on Fedora 5.19-rc8 on Ryzen 6800U

Open
#3,352 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp, linux

Research direction

Start in src/PerfCounters.cc at read_ticks(), line 810, and reproduce the adjusted_counting_period assertion on the reported Ryzen 6800U Fedora/Linux kernels. Run the listed affected rr tests and compare the detected tick counts with the expected limits; done means the failures are understood and the affected tests no longer hit this assertion.

Written by the indexing model from the issue text.

Description

I am experiencing 27 rr Test failures after merging support for Ryzen 6000 series (see PR #3351)

The processor is specifically 6800U. This is a custom Linux kernel -- essentially 5.19-rc8. I experience similar test failures on Fedora 5.18.xx series also.

Here are the failures:

52:x86/chew_cpu_cpuid
152:exit_with_syscallbuf_signal
418:no_mask_timeslice
419:no_mask_timeslice-no-syscallbuf
456:x86/pkeys
457:x86/pkeys-no-syscallbuf
816:unexpected_exit_pid_ns
872:async_kill_with_syscallbuf2
1001:ignored_async_usr1-no-syscallbuf
1070:reverse_continue_breakpoint
1071:reverse_continue_breakpoint-no-syscallbuf
1088:rseq
1089:rseq-no-syscallbuf
1310:record_replay
1394:term_trace_cpu
1395:term_trace_cpu-no-syscallbuf
1467:x86/chew_cpu_cpuid-32-no-syscallbuf
1870:x86/pkeys-32
1871:x86/pkeys-32-no-syscallbuf
2466:overflow_branch_counter-32
2467:overflow_branch_counter-32-no-syscallbuf
2484:reverse_continue_breakpoint-32
2485:reverse_continue_breakpoint-32-no-syscallbuf
2488:reverse_continue_process_signal-32
2493:reverse_step_long-32-no-syscallbuf
2502:rseq-32
2503:rseq-32-no-syscallbuf

Interestingly 26 of the failures are due to the puzzling assertion below. (Of course the number of ticks are different depending on the failed test)

[FATAL src/PerfCounters.cc:810:read_ticks()] 
 (task 133844 (rec:133838) at time 131)
 -> Assertion `!counting_period || interrupt_val <= adjusted_counting_period' failed to hold. Detected 508733 ticks, expected no more than 498183

This assertion has come up previously in various Zen related issues.

Please note that I tested with sudo sysctl -w kernel.perf_cpu_time_max_percent=100 not that it seemed to make any difference though...

Dominant language
C++
Stars
10.7k
Forks
662
Avg merge
2d 3h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rr-debugger/rr

All issues in rr-debugger/rr

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.