ASAN specific handling in chaos mode isn't triggered if Firefox is run from `mach`
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Reproduce the failure with rr record -h ./mach run using an ASAN Firefox build, then inspect the ASAN handling in src/AddressSpace.cc and executable checks in src/RecordSession.cc at the referenced lines. Compare this with recording the firefox-bin executable directly. Done means establishing and implementing or documenting a supported way for the mach launch path to use the required ASAN handling.
Written by the indexing model from the issue text.
Description
The handling to prevent chaos mode interfering with ASAN will only kick in if the executable passed to rr is flagged for ASAN. This is because only this executable is checked. My assumption is that it doesn't make sense to do this with later executables as there may then already be existing memory allocations that it is too late to deal with.
This means that something like rr record -h ./mach run will typically fail when it is an ASAN version of Firefox being run. This can be worked around by instead recording the firefox-bin executable that would be called by mach.
I'm not sure if this is a common enough use case to need action. I'm considering a local build with an extra flag that I can pass to force ASAN compat so I can keep using mach, but don't know if that's useful outside of my bubble.
- Dominant language
- C++
- Stars
- 10.7k
- Forks
- 662
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from rr-debugger/rr
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
rr-debugger/rr#4096 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
rr-debugger/rr#4093 · 6 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
rr-debugger/rr#4090 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
rr-debugger/rr#4060 · 5 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
rr-debugger/rr#4059 · 1 comment ·
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Sensor initialization takes very long when `--initial-sim-time` is set to current UNIX timestamp Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gazebosim/gz-sensors#662 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LadybirdBrowser/ladybird#12123 ·