ros2 / ros2/system_tests

:man_farmer: `test_communication` -> `test_subscriber_terminates_in_a_finite_amount_of_time` and `test_processes_finished_gracefully` failing on Windows

Open
#496 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Windows
Dominant language
C++
Stars
45
Forks
57
Avg merge
9h 19m
Merged PRs (30d)
2

Description

Bug report

Required Info:

  • Operating System:
    • Windows
  • Installation type:
    • Source
  • Version or commit hash:
    • main
  • DDS implementation:
    • Fast-RTPS
  • Client library (if applicable):
    • rclpy
Steps to reproduce issue

Check nightly windows jobs on the buildfarm.
Reference job showing an error in jenkins with both test_subscriber_terminates_in_a_finite_amount_of_time and test_processes_finished_gracefully failing.
https://ci.ros2.org/view/nightly/job/nightly_win_deb/2284/

Expected behavior

All test pass.

Actual behavior

These error appear constantly in the logs. It's flaky in the sense that the affected templated test differ from run to run, but most of the time at least one occur. However, important information, not all the times the error is shown in the jenkins report, for example, in the reference case attached above the following errors are shown in the UI:

projectroot.test_publisher_subscriber__rclpy__rmw_fastrtps_cpp
test_communication.TestPublisherSubscriber.test_subscriber_terminates_in_a_finite_amount_of_time[UnboundedSequences]
test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[UnboundedSequences]
test_communication.TestPublisherSubscriber.test_subscriber_terminates_in_a_finite_amount_of_time[WStrings]
test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[WStrings]

However, if you run grep on the log file looking for "FAIL: " you'll see the following list:

142: FAIL: test_subscriber_terminates_in_a_finite_amount_of_time[BoundedSequences] (test_communication.TestPublisherSubscriber)
142: FAIL: test_processes_finished_gracefully[BoundedSequences] (test_communication.TestPublisherSubscriberAfterShutdown)
143: FAIL: test_processes_finished_gracefully[Empty] (test_communication.TestRequesterReplierAfterShutdown)
142: FAIL: test_processes_finished_gracefully[Arrays] (test_communication.TestPublisherSubscriberAfterShutdown)
142: FAIL: test_subscriber_terminates_in_a_finite_amount_of_time[Empty] (test_communication.TestPublisherSubscriber)
142: FAIL: test_processes_finished_gracefully[Empty] (test_communication.TestPublisherSubscriberAfterShutdown)
142: FAIL: test_subscriber_terminates_in_a_finite_amount_of_time[Nested] (test_communication.TestPublisherSubscriber)
142: FAIL: test_processes_finished_gracefully[Nested] (test_communication.TestPublisherSubscriberAfterShutdown)
142: FAIL: test_processes_finished_gracefully[Strings] (test_communication.TestPublisherSubscriberAfterShutdown)
142: FAIL: test_processes_finished_gracefully[UnboundedSequences] (test_communication.TestPublisherSubscriberAfterShutdown)
142: FAIL: test_subscriber_terminates_in_a_finite_amount_of_time[WStrings] (test_communication.TestPublisherSubscriber)
142: FAIL: test_processes_finished_gracefully[WStrings] (test_communication.TestPublisherSubscriberAfterShutdown)
142: FAIL: test_subscriber_terminates_in_a_finite_amount_of_time[UnboundedSequences] (test_communication.TestPublisherSubscriber)
142: FAIL: test_processes_finished_gracefully[UnboundedSequences] (test_communication.TestPublisherSubscriberAfterShutdown)
142: FAIL: test_subscriber_terminates_in_a_finite_amount_of_time[WStrings] (test_communication.TestPublisherSubscriber)
142: FAIL: test_processes_finished_gracefully[WStrings] (test_communication.TestPublisherSubscriberAfterShutdown)

More info:
Templated tests: https://github.com/ros2/system_tests/blob/master/test_communication/test/test_publisher_subscriber.cpp
Actual test failures (problems related to finishing the process cleanly on windows):
https://github.com/ros2/system_tests/blob/44ac714f2cd201b2a2c98949595e953d5a289191/test_communication/test/test_publisher_subscriber.py.in#L67
and https://github.com/ros2/system_tests/blob/44ac714f2cd201b2a2c98949595e953d5a289191/test_communication/test/test_publisher_subscriber.py.in#L75

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test_communication/test/test_publisher_subscriber.cpp and the generated test_communication/test/test_publisher_subscriber.py.in around lines 67 and 75. Reproduce the failures in the nightly Windows job and compare the Jenkins UI with the full log, including the rclpy Fast-RTPS cases. Done means the affected communication and shutdown tests finish cleanly on Windows.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
operating-systems, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.