ros2 / ros2/system_tests

Re-enable cross-vendor tests on Windows

Open
#476 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
45
Forks
57
Avg merge
9h 19m
Merged PRs (30d)
2

Description

There is a TODO regarding disabled cross-vendor tests on Windows:

https://github.com/ros2/system_tests/blob/f460b6e82d0eae17b66f4ce038dd99d907bdf10d/test_communication/CMakeLists.txt#L160

It would be nice to resolve these and have the tests re-enabled again. I'm not sure what's required to make these tests pass.

Here's an older related PR: https://github.com/ros2/system_tests/pull/323
And an old issue that has been resolved: https://github.com/ros2/rmw_fastrtps/issues/246

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at test_communication/CMakeLists.txt around line 160 and inspect the TODO that disables the cross-vendor tests on Windows. Review the older PR #323 and the resolved rmw_fastrtps issue #246 for prior context, then run the relevant Windows tests. Done means the cross-vendor tests are re-enabled and pass on Windows.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, operating-systems, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.