ros2 / ros2/system_tests

take service server request fails but test succeeds

Open
#424 0 comments 0 reactions 1 assignee View on GitHub

@mjcarroll is already working on this.

Since May 4, 2020.

bug
Dominant language
C++
Stars
45
Forks
57
Avg merge
9h 19m
Merged PRs (30d)
2

Description

I noticed these anomalous results: https://ci.ros2.org/job/ci_windows/10042/consoleText
The weird part is [test_replier-1] [ERROR] [1586854796.352196400] [rclcpp]: executor taking a service server request from service '/test_time_08_59_55/test/service/Arrays' unexpectedly failed: error not set

It seems like maybe the test should be reporting failure, not success.

19: Starting test run test_communication.test_requester_replier__rclpy__rclcpp__rmw_connext_cpp_Release.launch_tests[Arrays]
19: [INFO] [launch]: All log files can be found below C:\Users\ContainerAdministrator\.ros/log\2020-04-14-08-59-55-155571-ee5129ec6efc-12504
19: [INFO] [launch]: Default logging verbosity is set to INFO
19: test_requester_finishes_in_a_finite_amount_of_time[Arrays] (test_communication.TestRequesterReplier)
19: Test that the second executable terminates after a finite amount of time. ... [INFO] [test_replier-1]: process started with pid [9268]
19: [INFO] [test_requester-2]: process started with pid [14304]
19: [test_replier-1] [ERROR] [1586854796.352196400] [rclcpp]: executor taking a service server request from service '/test_time_08_59_55/test/service/Arrays' unexpectedly failed: error not set
19: [INFO] [test_requester-2]: process has finished cleanly [pid 14304]
19: [WARNING] [test_replier-1]: 'SIGINT' sent to process[test_replier-1] not supported on Windows, escalating to 'SIGTERM'
19: [INFO] [test_replier-1]: sending signal 'SIGTERM' to process[test_replier-1]
19: [ERROR] [test_replier-1]: process has died [pid 9268, exit code 1, cmd 'C:/ci/ws/build/test_communication/Release/test_replier_cpp.exe Arrays /test_time_08_59_55'].
19: ok

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.