ros2 / ros2/system_tests

Move tests closer to the source code

Open
#396 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
C++
Stars
45
Forks
57
Avg merge
9h 19m
Merged PRs (30d)
2

Description

Feature request

Feature description

There are a bunch of tests that can be moved closer to the repository where the source code is.

e.g. all tests in tests_rclcpp can be moved to rclcpp.
See https://github.com/ros2/rclcpp/pull/931#issuecomment-561868473 discussion.

Probably, the sames apply to test_rclpy.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the tests_rclcpp and rclcpp repositories, then review the discussion in rclcpp pull request 931. Determine which tests belong with their source code and whether the same relocation applies to test_rclpy. Done means the applicable tests have been moved to the source repositories without losing coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.