ros2 / ros2/system_tests

FastRTPS/Connext Action tests are suspiciously short, and probably don't work

Open
#319 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog bug Connext FastRTPS
Dominant language
C++
Stars
45
Forks
57
Avg merge
9h 19m
Merged PRs (30d)
2

Description

Bug report

Required Info:

Steps to reproduce issue
  1. Run the action test using rclcpp with fastrtps and connext
colcon test --event-handlers console_direct+ --packages-select test_communication --ctest-args -R test_action_client_server__Fibonacci__rclcpp__rmw_fastrtps_cpp__rmw_connext_cpp
  1. Run the executables the above test should be running on their own
    RMW_IMPLEMENTATION=rmw_fastrtps_cpp ./build/test_communication/test_action_client_cpp Fibonacci /foo/bar
    
    RMW_IMPLEMENTATION=rmw_connext_cpp ./build/test_communication/test_action_server_cpp Fibonacci /foo/bar
    
Expected behavior
  1. The test would pass, taking about a second or so, and outputting info about goals and feedback
  2. Run independently the tests should output information about goals and feedback
Actual behavior
  1. The test passes in 0.1 seconds with no output
  2. Run independently the client says it sent a goal, but the server does not print a message saying it received it.
Additional information

Same behavior if the rmw implementations are flipped so it's a connext client with fastrtps server. If both are fastrtps or both are connext it works as expected. The service/client and subscriber/publisher tests appear to work fine across fastrtps and connext.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the test_action_client_server__Fibonacci__rclcpp__rmw_fastrtps_cpp__rmw_connext_cpp test in test_communication and reproduce it with the provided colcon test command. Then run test_action_client_cpp and test_action_server_cpp independently using the shown RMW implementations. Done means mixed Fast-RTPS and Connext action tests exchange goals and feedback and take about a second rather than passing silently.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
distributed-systems, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.