ros2 / ros2/ros2cli

ros2cli tests don't verify output stream

Open
#484 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog enhancement help wanted
Dominant language
Python
Stars
262
Forks
228
Avg merge
23h 15m
Merged PRs (30d)
12

Description

ros2cli tests don't verify which stream output comes out on (stdout vs stderr).

These tests should confirm that the expected output does indeed come out via the expected stream, instead of munging together stdout and stderr.

See related #482, which may be wholly or partially attributed to this issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the ros2cli tests that currently combine stdout and stderr, then read related issue #482 for context. Update the tests so expected output is checked against the correct stream separately; done means the tests distinguish stdout from stderr and still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.