[ros2lifecycle] set --include-hidden-nodes argument is unnecessary because node_name is required
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 262
- Forks
- 228
- Avg merge
- 23h 15m
- Merged PRs (30d)
- 12
Description
Same as ros2/ros2cli#171, but for ros2 lifecycle set.
Here's where the option is passed in
https://github.com/ros2/ros2cli/blob/af65db2d95fbbd436308d7fd363c6545342496ad/ros2lifecycle/ros2lifecycle/verb/set.py#L38-L40
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect ros2lifecycle/ros2lifecycle/verb/set.py at the referenced lines, then compare the related ros2/ros2cli#171 issue. Confirm that node_name is already required and identify the unnecessary --include-hidden-nodes option; done means that option is no longer passed by ros2 lifecycle set.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100