Removals in GraphQL-Ruby 3.0

Open
#4,778 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
20/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
graphql, ruby
Domain
backend-api-design

Research direction

Start by reviewing the unchecked items in the removal checklist and the referenced deprecation issues, especially #4878, #4771, #4996, #4813, #4867, #4807, and #4818. Trace each named legacy API, option, or constant through the repository; done means the remaining 3.0-dev removals and behavior changes are completed without leaving the deprecated interfaces in place.

Written by the indexing model from the issue text.

Description

There are many features in GraphQL-Ruby which have been replaced by better ones. In GraphQL-Ruby 3.0, I'd like to remove the old ones.

  • tracer(...)-style tracing, which is replaced with the more-efficient trace_with(...)-style tracing.
    • Deprecate #4878
    • Remove in 3.0-dev
    • Legacy PlatformTracing
      • Deprecate #4779
    • LegacyTrace
  • instrument(:query | :multiplex), which can also be replaced with trace_with(...)
    • Deprecate #4771
    • Remove in 3.0-dev
  • Move Analysis::AST to Analysis? Could still be aliased as AST.
    • Move and deprecate_const #4996
    • Remove in 3.0-dev
  • Get rid of old error bubbling option
    • Deprecated in #4813
    • Remove in 3.0-dev
  • Get rid of (query_|mutation_|subscription)_execution_strategy
    • Deprecate #4867
    • Remove in 3.0-dev
  • Remove lazy_resolve(Dataloader::Source::Request)
    • Deprecated in #4807
    • Remove in 3.0-dev
  • Remove nonblocking: true
    • Already deprecated
    • Remove in 3.0-dev
  • Remove parse_with_racc
    • Deprecated in #4818
    • Remove in 3.0-dev
  • Make reject_numbers_followed_by_names default to true instead of false (added in #4924)
  • Raise an error on empty Object and InputObject type definitions (followup on #5137)
  • Only call .visible? when using Visibility; remove warden
  • Remove Schema.allow_legacy_invalid_empty_selections_on_union
  • Remove Schema.allow_legacy_invalid_return_type_conflicts
  • Remove default_analysis_engine and default_execution_strategy
Dominant language
Ruby
Stars
5.4k
Forks
1.4k
Avg merge
23h 19m
Merged PRs (30d)
28

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rmosolgo/graphql-ruby

All issues in rmosolgo/graphql-ruby

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.